Delete old deploy scripts #978
Conversation
jmgrady
added
documentation
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 49.77% 49.79% +0.01%
==========================================
Files 236 236
Lines 6487 6487
Branches 394 394
==========================================
+ Hits 3229 3230 +1
Misses 2966 2966
+ Partials 292 291 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Reviewed 161 of 162 files at r1.
Reviewable status: 161 of 162 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
.gitmodules, line 3 at r2 (raw file):
[submodule "deploy/roles_common"] path = deploy/roles_common url = ../ops-ansible-common-roles.git
Shouldn't we delete this file instead of having it empty?
There was a problem hiding this comment.
We can also delete public/.htaccess, no?
Reviewable status: 161 of 162 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
No longer needed with NGINX reverse proxy server
There was a problem hiding this comment.
We can also delete public/.htaccess, no?
Done.
Reviewable status: 161 of 163 files reviewed, all discussions resolved (waiting on @jmgrady)
.gitmodules, line 3 at r2 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
Shouldn't we delete this file instead of having it empty?
Done
There was a problem hiding this comment.
Reviewed 2 of 4 files at r3.
Reviewable status: 163 of 165 files reviewed, all discussions resolved (waiting on @jmgrady)
There was a problem hiding this comment.
Reviewed 2 of 4 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:
Remove the old deployment scripts in
./deployand move the docker installation that is in./docker_depoyto the./deploydirectory. Also removes the old documentation in the./docsdirectory.Closes #953
This change is