Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Word.Modified timestamp on merge or delete #994

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Feb 5, 2021

Closes #960

  • Update Word.Modified when
    • Words are merged
    • Words are deleted (e.g. removed from frontier)

This change is Reviewable

@johnthagen johnthagen added bug Something isn't working backend labels Feb 5, 2021
@johnthagen johnthagen self-assigned this Feb 5, 2021
@codecov-io
Copy link

codecov-io commented Feb 5, 2021

Codecov Report

Merging #994 (5b3fe6b) into master (5f4387a) will decrease coverage by 0.05%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   49.79%   49.74%   -0.06%     
==========================================
  Files         236      236              
  Lines        6482     6489       +7     
  Branches      393      393              
==========================================
  Hits         3228     3228              
- Misses       2964     2971       +7     
  Partials      290      290              
Flag Coverage Δ
backend 55.48% <44.44%> (-0.12%) ⬇️
frontend 43.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Services/WordRepository.cs 17.56% <0.00%> (-1.01%) ⬇️
Backend/Services/WordApiServices.cs 89.04% <100.00%> (+0.46%) ⬆️
Backend/Helper/Time.cs 50.00% <0.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4387a...5b3fe6b. Read the comment docs.

@johnthagen johnthagen marked this pull request as ready for review February 5, 2021 20:57
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wish I could have worked out a good way to mock the database layer so that we could unit test our repositories, but mocking Mongo is too expensive and I'd prefer to avoid test databases. :LGTM:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@johnthagen johnthagen merged commit 19ad181 into master Feb 5, 2021
@johnthagen johnthagen deleted the merge-timestamps branch February 5, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track word modification time and export DateModified and DateCreated to LIFT
3 participants