Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cause npm run lint to fail if warnings are detected #999

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Feb 7, 2021

Currently if npm run lint is run and warnings are detected, the process does not fail. This means that when npm run lint is run on CI, it will not fail if ESLint warnings are pushed.

Fix this by failing if any warnings are detected by ESLint.


This change is Reviewable

@johnthagen johnthagen self-assigned this Feb 7, 2021
@johnthagen johnthagen added maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. and removed test labels Feb 7, 2021
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@codecov-io
Copy link

codecov-io commented Feb 8, 2021

Codecov Report

Merging #999 (27ccfb5) into master (43295a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   49.72%   49.72%           
=======================================
  Files         236      236           
  Lines        6492     6492           
  Branches      393      393           
=======================================
  Hits         3228     3228           
  Misses       2974     2974           
  Partials      290      290           
Flag Coverage Δ
backend 55.43% <ø> (ø)
frontend 43.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43295a9...27ccfb5. Read the comment docs.

@imnasnainaec imnasnainaec merged commit e34b70d into master Feb 8, 2021
@imnasnainaec imnasnainaec deleted the eslint-error-ci branch February 8, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants