Investigation into Svelte re-write #1005
Draft
+24,200
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvire
force-pushed
the
develop
branch
2 times, most recently
from
b3d0511
to
eb5224e
Compare
chrisvire
commented
Jun 12, 2024
| @@ -51,5 +51,8 @@ | |||
| "type": "module", | |||
| "volta": { | |||
| "node": "18.16.1" | |||
| }, | |||
| "dependencies": { | |||
| "zod": "^3.23.8" | |||
There was a problem hiding this comment.
Normally, all dependencies with Svelte-kit are devDependencies.
chrisvire
commented
Jun 12, 2024
| @@ -4,19 +4,31 @@ | |||
|
|
|||
| --> | |||
| <script lang="ts"> | |||
There was a problem hiding this comment.
FYI, "Internationalized" is probably not needed in the component name. Everything should internationalized.
7dev7urandom
force-pushed
the
feature/svelte
branch
from
c968d4f
to
5970039
Compare
FyreByrd
force-pushed
the
feature/svelte
branch
from
90f1c4b
to
098cc23
Compare
7dev7urandom
force-pushed
the
feature/svelte
branch
from
25ec08f
to
cdfa40c
Compare
FIX: Restore DWKit tables that were removed
chrisvire
force-pushed
the
feature/svelte
branch
from
a095467
to
473f529
Compare
* locale * navbar
* still needs sizing of boxes and buttons
- Add test button to create bullmq task in admin settings
* Add Aidan Jones to users * Add alt for testing non-admin visibility
* Import prisma in flows and auth * Add structure for task forms * Direct my tasks links to correct subfolder * Add rest of instructions * Use instructions dynamically in svelte:component Also fixed some things to make TS happy. * Make tables in forms sortable * Add simple queries and log results * Add comments noting which database field * Retrieve product data from database Currently grabbing all relevant fields. Once workflow backend is implemented, should change to only grab data needed based on the state of the task in the workflow. * Move arrow icons to lib/icons * Rename fields to be more meaningful * Rename instructions to align with DWKit forms * Remove unneeded query * Add note for ProductArtifacts * Clean up code for SortTable and co. * Break out artifacts query, filter on latest build --------- Co-authored-by: 7dev7urandom <30197373+7dev7urandom@users.noreply.github.com>
(at build time only)
chrisvire
force-pushed
the
feature/svelte
branch
from
473f529
to
52fd74c
Compare
The provided link to current tasks when viewing a product in the projects page pointed to the wrong endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.