-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook Workflow into BuildEngine #1020
Draft
FyreByrd
wants to merge
28
commits into
feature/svelte-workflows
Choose a base branch
from
feature/svelte-flow-buildengine
base: feature/svelte-workflows
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Hook Workflow into BuildEngine #1020
FyreByrd
wants to merge
28
commits into
feature/svelte-workflows
from
feature/svelte-flow-buildengine
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FyreByrd
force-pushed
the
feature/svelte-flow-buildengine
branch
3 times, most recently
from
October 3, 2024 15:30
34a5f71
to
26c59fc
Compare
FyreByrd
force-pushed
the
feature/svelte-workflows
branch
from
October 4, 2024 13:24
e3094e9
to
6f1e44c
Compare
FyreByrd
force-pushed
the
feature/svelte-flow-buildengine
branch
8 times, most recently
from
October 10, 2024 15:40
834b80c
to
e8e6651
Compare
FyreByrd
force-pushed
the
feature/svelte-flow-buildengine
branch
2 times, most recently
from
October 16, 2024 18:27
1baa977
to
57a821e
Compare
- Create Product - Build Product - Publish Product
That was the problem? Seriously???
Handles multiple potential use cases: - Reassign tasks from one list of users to another. - Delete all tasks for a product/project, optionally limit by user or user role. - Create new tasks, optionally by user or role. - Update tasks, optionally by user or role. (This is the main one used by workflow) In all cases, can be applied to either a single product, or all products within a project. Will also refresh the PreExecuteEntries (i.e. blank-ish ProductTransitions that show the ideal path beyond the current workflow state). Updated `databaseWrites/Projects.ts` and `workflow/index.ts` to use the new code.
Will this result in the desired behavior if a user has multiple roles? What if, for some unfathomable reason, a user is both a project owner and an Author on the same project? As of right now, all tasks for that user in that project will be deleted, regardless of role. Should a user be prevented from having more than one role for a project?
FyreByrd
force-pushed
the
feature/svelte-flow-buildengine
branch
from
October 18, 2024 12:50
57a821e
to
95bb408
Compare
Can we please handle this on the db/orm level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will probably need to be closed and reopened as a new one once feature/svelte-workflows is merged.