Skip to content

Commit

Permalink
Clarify reason for using ValueTuple 4.4 for netstandard1.6 (#175)
Browse files Browse the repository at this point in the history
  • Loading branch information
ermshiperete authored Oct 17, 2022
1 parent 1646551 commit a426c10
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions source/icu.net/icu.net.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.6'">
<!--System.ValueTuple v4.5 caused MSB3277 when consuming LibChorus in LibTriboroughBridge-ChorusPlugin -->
<!-- The reason is that .NET Standard comes with System.ValueTuple AssemblyVersion 4.0.2 -->
<!-- which corresponds to package version 4.4.0 -->
<PackageReference Include="System.ValueTuple" Version="4.4.0" />
<PackageReference Include="System.Diagnostics.TraceSource" Version="4.3.0" />
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
Expand Down

0 comments on commit a426c10

Please sign in to comment.