Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Mac support #192

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

imnasnainaec
Copy link
Contributor

In Platform.cs, enable distinguishing MacOSX from Unix on all of .NET Core and Standard, not just .NET Standard 1.6.
In NativeMethods.cs > CheckDirectoryForIcuBinaries, compute library name length.
In NativeMethods.cs > LocateIcuLibrary, add osx and expand options.

Copy link

Test Results

       3 files  ±0     241 suites  ±0   4s ⏱️ ±0s
   431 tests ±0     423 ✔️ ±0    8 💤 ±0  0 ±0 
1 309 runs  ±0  1 254 ✔️ ±0  55 💤 ±0  0 ±0 

Results for commit 1e85346. ± Comparison against base commit b990d03.

Copy link
Member

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ermshiperete ermshiperete merged commit 5979f1c into sillsdev:master Mar 27, 2024
5 checks passed
@imnasnainaec imnasnainaec deleted the LocateIcuLibrary branch March 27, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants