Fix builds on macOS #194
Merged
Fix builds on macOS #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahn-kev
reviewed
Jun 3, 2024
imnasnainaec
reviewed
Jun 4, 2024
imnasnainaec
reviewed
Jun 4, 2024
imnasnainaec
reviewed
Jun 4, 2024
jasonleenaylor
approved these changes
Jun 5, 2024
srl295
reviewed
Jun 11, 2024
Comment on lines
+54
to
+56
| [TestCase("en_US", ExpectedResult = "[abcdefghijklmnopqrstuvwxyz]")] | ||
| [TestCase("de_DE", ExpectedResult = "[aäbcdefghijklmnoöpqrsßtuüvwxyz]")] | ||
| [TestCase("fr_FR", ExpectedResult = "[aàâæbcçdeéèêëfghiîïjklmnoôœpqrstuùûüvwxyÿz]")] |
There was a problem hiding this comment.
this is locale data so of course it could change or be reformatted.
If you have ICU here, you could actually parse it into a UnicodeSet and do a comparison there.
There was a problem hiding this comment.
substring containment might be a quicker option.. i.e. make sure that english contains a, b, z, German contains ß etc.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a number of problems with using icu-dotnet on macOS. It helps with a number of issues found in paranext/paranext-core#264.
This change adds macOS to the github builds so that future breaks should be caught by normal CI/CD workflows.