Fix dynamic library loading on macOS #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
On line 78, the Unix should probably be changed back to Linux if those methods aren't being used for Mac any more.
There was a problem hiding this comment.
On line 387, I think Trace.TraceWarning("{0} of {1} failed with error {2}", IsWindows ? "LoadLibraryEx" : "dlopen", libPath, lastError); needs a middle IsMac case added.
There was a problem hiding this comment.
Thanks - fixed both of these
lyonsil
force-pushed
the
macos-dynamic-library-loading
branch
2 times, most recently
from
ba3bae0
to
b04fa87
Compare
lyonsil
force-pushed
the
macos-dynamic-library-loading
branch
from
b04fa87
to
c0eba81
Compare
This was referenced Jun 14, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.