Use NativeLibrary for all OSes

[imnasnainaec]

No description provided.

[lyonsil]

At a high level these changes make sense to me. Other than the one thing I pointed out with dlerror, my only concern is how much testing this might need on Windows and Linux to make sure there isn't some unexpected impact. NativeLibrary should work fine, but I don't think the unit tests really exercise dynamic library loading deeply (e.g., does NativeLibrary follow all the same path searching rules that libdl uses?). I'm guessing it will not be a problem, but that's just a guess.

[imnasnainaec]

At a high level these changes make sense to me. Other than the one thing I pointed out with dlerror, my only concern is how much testing this might need on Windows and Linux to make sure there isn't some unexpected impact. NativeLibrary should work fine, but I don't think the unit tests really exercise dynamic library loading deeply (e.g., does NativeLibrary follow all the same path searching rules that libdl uses?). I'm guessing it will not be a problem, but that's just a guess.

@lyonsil Yeah, I was having similar concerns, so I left this in draft until it could be given more thorough consideration.

[github-actions]

Test Results

       5 files  ±0     403 suites  ±0   5s ⏱️ -1s
   431 tests ±0     427 ✔️ ±0    4 💤 ±0  0 ❌ ±0 
2 193 runs  ±0  2 095 ✔️ ±0  98 💤 ±0  0 ❌ ±0 

Results for commit 4137022. ± Comparison against base commit fddc930.

♻️ This comment has been updated with latest results.

[lyonsil]

Looks good to me. The overall question about "how do we know that NativeLibrary will be functionally compatible with the previous approach for Windows and Linux users on .NET 6.0 or later?" is still there, but I don't see anything in these changes that looks like a regression or a problem.

[imnasnainaec]

Looks good to me. The overall question about "how do we know that NativeLibrary will be functionally compatible with the previous approach for Windows and Linux users on .NET 6.0 or later?" is still there, but I don't see anything in these changes that looks like a regression or a problem.

I'll try to test it out more.

For reference, here's the code NativeLibrary uses: for Unix; for Windows

[imnasnainaec]

For Unix, it uses [LibraryImport(Interop.Libraries.SystemNative, EntryPoint = "SystemNative_LoadLibrary", StringMarshalling = StringMarshalling.Utf8)] (in Interop.Sys)

[jasonleenaylor]

I verified (using a locally built package with FieldWorks) that this code does not disrupt the framework clients of the .dll, and I don't see any reason that it shouldn't work for dotnet clients on Windows.