Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid Uri error when running in a Single file application #201

Merged
merged 2 commits into from
Jul 4, 2024
Merged

fix invalid Uri error when running in a Single file application #201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1562a70
fallback to AppContext.BaseDirectory if Assembly.Location is null whe…
hahn-kev Jul 2, 2024
c39404e
update code comment
hahn-kev Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/icu.net/NativeMethods/NativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,12 @@ internal static string DirectoryOfThisAssembly
#endif
#if NET
var managedPath = currentAssembly.Location;
// If the application is published as a single file, Assembly.Location will be an empty string.
// Per the warning https://learn.microsoft.com/en-us/dotnet/core/deploying/single-file/warnings/il3000 we should use AppContext.BaseDirectory instead.
if (string.IsNullOrEmpty(managedPath))
{
managedPath = AppContext.BaseDirectory;
}
#else
var managedPath = currentAssembly.CodeBase ?? currentAssembly.Location;
#endif
Expand Down
Loading