LT-21760: Prevent Find and Fix from dropping homograph numbers

[JakeOliver28]

This change is 

[jasonleenaylor]

tests/SIL.LCModel.FixData.Tests/FwDataFixerTests.cs line 869 at r1 (raw file):

		/// </summary>
		[Test]
		public void HomographNumberDrops()

I would name the test HomographFixerIgnoresAlternativeCitationForms

[jasonleenaylor]

src/SIL.LCModel.FixData/HomographFixer.cs line 149 at r1 (raw file):

				// if there was a citation form which matches the form of this MoStemAllomorph the MorphType
				// is not important to the homograph determination.
				if (m_Homographs.ContainsKey(rtFormText) || m_MorphTypeSort.Any())

Was this change still necessary?

[JakeOliver28]

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @jasonleenaylor)

---

src/SIL.LCModel.FixData/HomographFixer.cs line 149 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Was this change still necessary?

I'm honestly not sure how necessary the change is, but it does safe guard against a potential KeyNotFoundException. Do you think this is significant enough to leave in or should I remove it? Or should I do some more digging to check if I can find a case where the error occurs?

[jasonleenaylor]

src/SIL.LCModel.FixData/HomographFixer.cs line 149 at r1 (raw file):

Previously, JakeOliver28 (Jake Oliver) wrote…

I'm honestly not sure how necessary the change is, but it does safe guard against a potential KeyNotFoundException. Do you think this is significant enough to leave in or should I remove it? Or should I do some more digging to check if I can find a case where the error occurs?

I suppose there could be real data where this could cause a crash, so I think it is fine to leave it.

[JakeOliver28]

Test case renamed

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @jasonleenaylor)