run writingsystem tests against dotnet 8 to show a bug in the integration between icu.net and SIL.WritingSystems #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add a test to exhibit an issue with icu.net and SIL.WritingSystems when using net8.0
…hecking for "Unknown Language" in the name. Fixes a number of tests that were failing due to incorrectly detecting unknown cultures.
…ver specified and expect NLS (Windows only globalization) to be used instead of ICU.
# Conflicts: # SIL.Core/Reflection/ReflectionHelper.cs
|
It looks like a lot of our WritingSystem tests (especially related to sorting) are not expecting dotnet 8 to use ICU natively. To resolve this I went ahead and used a configuration flag so that instead of dotnet using ICU it will use NLS which is what .Net Framework uses, this meets the expectations of our tests. That said many of these tests may be over specified, so we should consider if we want to change them or not. |
…-writingsystems-dotnet-8 # Conflicts: # SIL.WritingSystems.Tests/SIL.WritingSystems.Tests.csproj
|
closed in favor of #1336 which is not based on a fork meaning there's no issue publishing the test results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See explanation of the issue sillsdev/icu-dotnet#202,
this PR just adds a test to use
IcuRulesCollator.GetSortKeywhich shows the current issue. Fixing this depends on the above PR being merged.This change is