Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-12 GHA runner #109

Merged
merged 1 commit into from
May 9, 2024
Merged

Use macos-12 GHA runner #109

merged 1 commit into from
May 9, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented May 9, 2024

  • sil-thot currently doesn't support ARM on MacOS

This change is Reviewable

- sil-thot currently doesn't support ARM on MacOS
@ddaspit ddaspit mentioned this pull request May 9, 2024
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135
Copy link
Collaborator

@ddaspit it appears that there are still required tests for the latest Mac OS build. Those need to be updated to just look for OS 12.

@ddaspit ddaspit merged commit f8f3fc5 into main May 9, 2024
14 checks passed
@ddaspit ddaspit deleted the macos-12 branch May 9, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants