Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error when passing an invalid lang code to HuggingFaceNmtEngine #50

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Raise error when passing an invalid lang code to HuggingFaceNmtEngine #50

merged 1 commit into from
Oct 30, 2023

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Oct 27, 2023 •
edited
Loading

This change is Reviewable

johnml1135
johnml1135 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 4f374c5 into main Oct 30, 2023
14 checks passed
@ddaspit ddaspit deleted the invalid-lang-code branch October 31, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnml1135 johnml1135 johnml1135 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddaspit @johnml1135