Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code from NmtModelFactory #69

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Nov 22, 2023

This change is Reviewable

@ddaspit ddaspit merged commit 9b68138 into main Nov 22, 2023
13 checks passed
@ddaspit ddaspit deleted the nmt-model-factory-cleanup branch November 22, 2023 17:53
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not removing this earlier.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants