Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_chapters to more similarly to get_books #80

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

isaac091
Copy link
Collaborator

@isaac091 isaac091 commented Dec 4, 2023

Update get_chapters to work more similarly to get_books.

This change is Reviewable

@isaac091 isaac091 requested a review from ddaspit December 4, 2023 14:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.84%. Comparing base (644f256) to head (3dbc5c6).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files         226      226           
  Lines       13606    13608    +2     
=======================================
+ Hits        11816    11818    +2     
  Misses       1790     1790           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @isaac091)

@isaac091 isaac091 merged commit 1df88d4 into main Dec 4, 2023
14 checks passed
@isaac091 isaac091 deleted the get_chapters_update branch December 4, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants