Create more robust check for old vs new book selection syntax #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e more descriptive error messages when syntaxes are mixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 86.80% 86.82% +0.01%
==========================================
Files 226 226
Lines 13608 13629 +21
==========================================
+ Hits 11813 11833 +20
- Misses 1795 1796 +1 ☔ View full report in Codecov by Sentry. |
…ma-separated syntax after the first selection
ddaspit
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @isaac091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create more robust check for old vs new book selection syntax and give more descriptive error messages when syntaxes are mixed. Previous version allowed some things, e.g. ranges of books, to be used with the comma-separated syntax, but not others, e.g. chapter selections, and that was confusing. This version allows only basic book and testament selection to be separated with commas, which matches the get_books function, and adds error messages that tell the user they may have mixed syntaxes when there is a parsing error.
This change is