default to major biblical terms (#180)

* default to major biblical terms - sillsdev/serval#357 Update tests - target-1 does not include BiblicalTermsListSetting to invoke default. * fix
sillsdev · Apr 10, 2024 · fa65835 · fa65835
1 parent 293bbdf
commit fa65835
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs b/src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs
@@ -82,8 +82,19 @@ public ParatextProjectSettings Parse()
                     suffix = postPart;
             }
 
-            string biblicalTerms = settingsDoc.Root.Element("BiblicalTermsListSetting").Value;
-            string[] parts = biblicalTerms.Split(new[] { ':' }, 3);
+            string biblicalTermsListSetting = settingsDoc.Root.Element("BiblicalTermsListSetting")?.Value;
+            if (biblicalTermsListSetting == null)
+                // Default to Major::BiblicalTerms.xml to mirror Paratext behavior
+                biblicalTermsListSetting = "Major::BiblicalTerms.xml";
+
+            string[] parts = biblicalTermsListSetting.Split(new[] { ':' }, 3);
+            if (parts.Length != 3)
+            {
+                throw new InvalidOperationException(
+                    $"The BiblicalTermsListSetting element in Settings.xml in project {fullName}"
+                        + $" is not in the expected format (i.e., Major::BiblicalTerms.xml) but is {biblicalTermsListSetting}."
+                );
+            }
 
             return new ParatextProjectSettings(
                 name,

diff --git a/tests/SIL.Machine.AspNetCore.Tests/Services/data/pt-target1/Settings.xml b/tests/SIL.Machine.AspNetCore.Tests/Services/data/pt-target1/Settings.xml
@@ -19,7 +19,6 @@
   <FileNameBookNameForm>41MAT</FileNameBookNameForm>
   <FileNamePrePart />
   <FileNamePostPart>Ten.SFM</FileNamePostPart>
-  <BiblicalTermsListSetting>Major::BiblicalTerms.xml</BiblicalTermsListSetting>
   <MatchBasedOnStems>F</MatchBasedOnStems>
   <AllowReadAccess>F</AllowReadAccess>
   <AllowSharingWithSLDR>F</AllowSharingWithSLDR>