Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed shared file folder to ClearML NMT job #157

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Jan 12, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d941cd2) 66.11% compared to head (89c2786) 66.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   66.11%   66.11%           
=======================================
  Files         428      428           
  Lines       33489    33493    +4     
  Branches     4498     4498           
=======================================
+ Hits        22141    22145    +4     
  Misses      10264    10264           
  Partials     1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

Where is the issue that documents the bug/enhancement?

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit c843ccd into master Jan 16, 2024
4 checks passed
@johnml1135
Copy link
Collaborator

This resolves this: sillsdev/machine.py#94

@ddaspit ddaspit deleted the shared-file-folder branch January 17, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants