-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update machine version #183
Conversation
If we are going to lock down the pull request and commits directly to main, we need to have an efficient release process that doesn't require pull requests, etc. One option could be https://github.com/versionize/versionize?tab=readme-ov-file. It may require a bit more research, especially looking at using conventional commits throughout, but it may be valuable long term. |
Previously, johnml1135 (John Lambert) wrote…
Actually versionize also commits directly to main - let me see if there is another way around this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 67.04% 67.04%
=======================================
Files 441 441
Lines 34831 34831
Branches 4670 4670
=======================================
Hits 23351 23351
Misses 10387 10387
Partials 1093 1093 ☔ View full report in Codecov by Sentry. |
Previously, johnml1135 (John Lambert) wrote…
In looking at the various options, I am inclined to think that we should just allow commits to master. We make make explicit the convention that we have been using, namely that commits can be made directly to master for:
|
Previously, johnml1135 (John Lambert) wrote…
Also, should I be an admin on Machine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)
src/AssemblyInfo.props
line 6 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Also, should I be an admin on Machine?
I'm not sure I understand the issue with using PRs. I think it makes sense that updating the version should be reviewed.
This change is