Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update machine version #183

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update machine version #183

merged 1 commit into from
Apr 16, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Apr 12, 2024

This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit April 12, 2024 12:10
@johnml1135
Copy link
Collaborator Author

src/AssemblyInfo.props line 6 at r1 (raw file):

		<Version Condition=" '$(VersionSuffix)' != '' ">$(Version)-$(VersionSuffix)</Version>
		<AssemblyVersion>3.1.0.0</AssemblyVersion>
		<FileVersion>3.1.0.0</FileVersion>

If we are going to lock down the pull request and commits directly to main, we need to have an efficient release process that doesn't require pull requests, etc. One option could be https://github.com/versionize/versionize?tab=readme-ov-file. It may require a bit more research, especially looking at using conventional commits throughout, but it may be valuable long term.

@johnml1135
Copy link
Collaborator Author

src/AssemblyInfo.props line 6 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

If we are going to lock down the pull request and commits directly to main, we need to have an efficient release process that doesn't require pull requests, etc. One option could be https://github.com/versionize/versionize?tab=readme-ov-file. It may require a bit more research, especially looking at using conventional commits throughout, but it may be valuable long term.

Actually versionize also commits directly to main - let me see if there is another way around this.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.04%. Comparing base (a9058ce) to head (d1392d3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   67.04%   67.04%           
=======================================
  Files         441      441           
  Lines       34831    34831           
  Branches     4670     4670           
=======================================
  Hits        23351    23351           
  Misses      10387    10387           
  Partials     1093     1093           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator Author

src/AssemblyInfo.props line 6 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Actually versionize also commits directly to main - let me see if there is another way around this.

In looking at the various options, I am inclined to think that we should just allow commits to master. We make make explicit the convention that we have been using, namely that commits can be made directly to master for:

  • Version increments and releases
  • CI updates
  • Documentation updates? (do we want to review these? Are any documentation updates ok? What about Swagger documentation, or Readme?)
    • For documentation, although I have committed documentation directly to master before, the urgency and complex dependencies for CI and versioning are not there while the importance of discretion, wording and clarity is. Let's say that all documentation updates need a pull request.

@johnml1135
Copy link
Collaborator Author

src/AssemblyInfo.props line 6 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

In looking at the various options, I am inclined to think that we should just allow commits to master. We make make explicit the convention that we have been using, namely that commits can be made directly to master for:

  • Version increments and releases
  • CI updates
  • Documentation updates? (do we want to review these? Are any documentation updates ok? What about Swagger documentation, or Readme?)
    • For documentation, although I have committed documentation directly to master before, the urgency and complex dependencies for CI and versioning are not there while the importance of discretion, wording and clarity is. Let's say that all documentation updates need a pull request.

Also, should I be an admin on Machine?

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


src/AssemblyInfo.props line 6 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Also, should I be an admin on Machine?

I'm not sure I understand the issue with using PRs. I think it makes sense that updating the version should be reviewed.

@johnml1135 johnml1135 merged commit c4b9581 into master Apr 16, 2024
4 checks passed
@ddaspit ddaspit deleted the machine_3.1.0 branch April 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants