Usfm parse error logging

[johnml1135]

Fixes:
sillsdev/serval#376
sillsdev/serval#375

---

This change is 

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.15%. Comparing base (321c6e7) to head (067b83d).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   67.12%   67.15%   +0.02%     
==========================================
  Files         441      441              
  Lines       34890    34890              
  Branches     4672     4672              
==========================================
+ Hits        23421    23430       +9     
+ Misses      10376    10368       -8     
+ Partials     1093     1092       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ddaspit]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

src/SIL.Machine/Corpora/UsfmFileText.cs line 48 at r1 (raw file):

                }
            }
            // It's not in the file contents, let's just pull it from the filename

I don't believe that this will fix the issue. The crash is occurring in UsfmZipText. Also, this is not generic enough, since the file name in a PT project is configurable. We should use the file naming setting in the PT project settings to determine how to properly parse the file name. I think we should wait until we get more information before we submit a fix for this issue.

[johnml1135]

src/SIL.Machine/Corpora/UsfmFileText.cs line 48 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

I don't believe that this will fix the issue. The crash is occurring in UsfmZipText. Also, this is not generic enough, since the file name in a PT project is configurable. We should use the file naming setting in the PT project settings to determine how to properly parse the file name. I think we should wait until we get more information before we submit a fix for this issue.

Fine enough - I reverted the fix. The other work is more important for today.

[ddaspit]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)