Removed cancellation token passing after line 99.

Opted to explicitly pass CancellationToken.None rather than leaving default for consistency with other code and added clarity. Fixes Cancellation token - inconsistent SMT training state #62 --ECL
sillsdev · Sep 5, 2023 · 4bc911a · 4bc911a
1 parent 609a24e
commit 4bc911a
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/Machine/src/SIL.Machine.AspNetCore/Services/SmtTransferEngineBuildJob.cs b/src/Machine/src/SIL.Machine.AspNetCore/Services/SmtTransferEngineBuildJob.cs
@@ -97,13 +97,12 @@ CancellationToken cancellationToken
             await using (await rwLock.WriterLockAsync(cancellationToken: cancellationToken))
             {
                 cancellationToken.ThrowIfCancellationRequested();
-                await smtModelTrainer.SaveAsync(cancellationToken);
-                await truecaseTrainer.SaveAsync(cancellationToken);
-                cancellationToken.ThrowIfCancellationRequested();
+                await smtModelTrainer.SaveAsync(CancellationToken.None);
+                await truecaseTrainer.SaveAsync(CancellationToken.None);
                 ITruecaser truecaser = await _truecaserFactory.CreateAsync(engineId);
                 IReadOnlyList<TrainSegmentPair> segmentPairs = await _trainSegmentPairs.GetAllAsync(
                     p => p.TranslationEngineRef == engine!.Id,
-                    cancellationToken
+                    CancellationToken.None
                 );
                 using (
                     IInteractiveTranslationModel smtModel = _smtModelFactory.Create(
@@ -119,9 +118,8 @@ CancellationToken cancellationToken
                         await smtModel.TrainSegmentAsync(
                             segmentPair.Source,
                             segmentPair.Target,
-                            cancellationToken: cancellationToken
+                            cancellationToken: CancellationToken.None
                         );
-                        cancellationToken.ThrowIfCancellationRequested();
                     }
                 }