Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#285 - fix it #291

Merged
merged 2 commits into from
Jan 31, 2024
Merged

#285 - fix it #291

merged 2 commits into from
Jan 31, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jan 30, 2024

Simple, tested manually.


This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4c45abf) 71.23% compared to head (29f0841) 71.21%.

Files Patch % Lines
...val.Translation/Services/GrpcServiceHealthCheck.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   71.23%   71.21%   -0.03%     
==========================================
  Files         141      141              
  Lines        6498     6500       +2     
  Branches     1060     1060              
==========================================
  Hits         4629     4629              
- Misses       1429     1431       +2     
  Partials      440      440              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)


src/Serval.Translation/Services/GrpcServiceHealthCheck.cs line 36 at r1 (raw file):

                status: (HealthStatus)healthCheckResponse.Status,
                description: context.Registration.Name,
                exception: (healthCheckResponse.Error is null || healthCheckResponse.Error == "")

You could use string.IsNullOrEmpty().

@johnml1135 johnml1135 merged commit bf93667 into main Jan 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants