Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Machine 3.0.2 #305

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Update to Machine 3.0.2 #305

merged 2 commits into from
Feb 7, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Feb 7, 2024

This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit February 7, 2024 17:39
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed a fix to the logic - a couple integration tests weren't passing. This is what I was saying earlier about the CI build. If there's a dependency issue, we can't see the results of the testing - i.e., are there any logic issues once everything gets updated? We could make a habit of running locally, I suppose, but that's not quite as convenient or as safe as the CI telling you on push. Regardless, like you say, there will still have to be a proper order to things that would eventually reveal these issues; it's just that often I'm trying to prepare two parallel PRs to completion and then deal with the dependency issues.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @ddaspit)

@Enkidu93 Enkidu93 merged commit bb5b1be into main Feb 7, 2024
1 of 2 checks passed
@Enkidu93 Enkidu93 deleted the machine_3.0.2 branch February 7, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants