Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Serval App #341

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Update Serval App #341

merged 1 commit into from
Mar 1, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Feb 29, 2024

  • Cache token in db
  • Remove emailing and background process
  • Add build-visibility
  • Be able to delete, cancel, download pretranslations, and download the model from a build

This change is Reviewable

*Add build-visibility
*Be able to delete, cancel, download pretranslations, and download the model from a build
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (5bdf74b) to head (b3a2242).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files         151      151           
  Lines        7049     7049           
  Branches     1120     1120           
=======================================
  Hits         4953     4953           
  Misses       1642     1642           
  Partials      454      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135 johnml1135 merged commit 3c548cf into main Mar 1, 2024
2 checks passed
@johnml1135 johnml1135 deleted the update_serval_app branch March 1, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants