Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serval app #345

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Update serval app #345

merged 4 commits into from
Mar 7, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Mar 6, 2024

Sorry, John, streamlit is complaining about the poetry lock - I don't see appreciable changes from running the command and it works fine locally from within the poetry env so I'm not sure what's going on. Hopefully, this resolves it.

I guess I should have rebased before making a PR? It shouldn't matter though, right?


This change is Reviewable

*Add build-visibility
*Be able to delete, cancel, download pretranslations, and download the model from a build
@Enkidu93 Enkidu93 requested a review from johnml1135 March 6, 2024 15:30
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@Enkidu93 Enkidu93 merged commit 8c8e58e into main Mar 7, 2024
1 of 2 checks passed
@Enkidu93 Enkidu93 deleted the update_serval_app branch March 7, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants