Do not train/pretranslate all if textIds is an empty array

[ddaspit]

• only train/pretranslate all if both textIds and scriptureRange are not specified
• fixes Already written text is not pretranslated if no trainOn books are specified #383

---

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.81%. Comparing base (85d87f5) to head (7d6f2be).

Files	Patch %	Lines
src/Serval.Translation/Services/EngineService.cs	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files         151      151           
  Lines        7172     7172           
  Branches     1121     1121           
=======================================
  Hits         5079     5079           
  Misses       1638     1638           
  Partials      455      455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johnml1135]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

---

src/Serval.Translation/Services/EngineService.cs line 235 at r1 (raw file):

                        {
                            corpus.PretranslateAll =
                                pretranslateCorpus.TextIds is null && pretranslateCorpus.ScriptureRange is null;

This looks great - should there be a test confirming that it works like this?

[ddaspit]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

src/Serval.Translation/Services/EngineService.cs line 235 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

This looks great - should there be a test confirming that it works like this?

Done.

[johnml1135]

This should also resolve #385 - to pretranslate on all, both textId and ScriptureRange need to be null, not just textId.

[johnml1135]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)