-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow textId or scriptureRange in a buildID. #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)
src/Serval.Translation/Services/EngineService.cs
line 238 at r1 (raw file):
{ throw new InvalidOperationException( $"The corpus {c.Id} cannot specify both 'textIds' and 'scriptureRange' for pretranslate"
You should end exception messages with a period. Also, it would be good to put quotes around "pretranslate", since that is a JSON property.
Previously, ddaspit (Damien Daspit) wrote…
Done. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 71.31% 71.21% -0.10%
==========================================
Files 151 151
Lines 7177 7189 +12
Branches 1124 1126 +2
==========================================
+ Hits 5118 5120 +2
- Misses 1604 1612 +8
- Partials 455 457 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
This change is