Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow textId or scriptureRange in a buildID. #401

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jun 7, 2024

This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit June 7, 2024 19:12
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


src/Serval.Translation/Services/EngineService.cs line 238 at r1 (raw file):

                            {
                                throw new InvalidOperationException(
                                    $"The corpus {c.Id} cannot specify both 'textIds' and 'scriptureRange' for pretranslate"

You should end exception messages with a period. Also, it would be good to put quotes around "pretranslate", since that is a JSON property.

@johnml1135
Copy link
Collaborator Author

src/Serval.Translation/Services/EngineService.cs line 238 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You should end exception messages with a period. Also, it would be good to put quotes around "pretranslate", since that is a JSON property.

Done.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (f070a15) to head (a17052a).

Files Patch % Lines
src/Serval.Translation/Services/EngineService.cs 16.66% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   71.31%   71.21%   -0.10%     
==========================================
  Files         151      151              
  Lines        7177     7189      +12     
  Branches     1124     1126       +2     
==========================================
+ Hits         5118     5120       +2     
- Misses       1604     1612       +8     
- Partials      455      457       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 68a0374 into main Jun 10, 2024
1 check passed
@johnml1135 johnml1135 deleted the textid_or_scripturerange branch June 10, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants