Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
- moved to using a compound run statement in both yml files
- had to shift around the working directory a bit
  • Loading branch information
megahirt committed Mar 27, 2022
1 parent 21cd12e commit 562455b
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 19 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/integrate-and-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,11 @@ jobs:
name: Unit Tests
run: make unit-tests-ci
-
name: Setup Playwright E2E test environment
run: docker-compose up -d app-for-playwright
working-directory: docker
-
run: npx playwright install
-
run: npx playwright test
name: Playwright E2E Tests
run: |
docker-compose -f docker/docker-compose.yml up -d app-for-playwright
npx playwright install
npx playwright test
-
name: Log in to Docker Hub
uses: docker/login-action@v1
Expand Down
23 changes: 11 additions & 12 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
-
uses: actions/checkout@v2
-
name: Run Unit Tests
name: Unit Tests
run: make unit-tests-ci
-
name: Publish Test Results
Expand All @@ -43,19 +43,18 @@ jobs:
node-version: '16.14.0'
cache: 'npm'
-
run: npm ci
name: Build app
run: |
npm ci
docker-compose build app
-
run: docker-compose build app
-
run: docker-compose up -d app-for-playwright

# see https://playwright.dev/docs/ci#github-actions
-
run: npx playwright install
working-directory: .
-
run: npx playwright test
name: Playwright E2E Tests
working-directory: .
# see https://playwright.dev/docs/ci#github-actions
run: |
docker-compose -f docker/docker-compose.yml up -d app-for-playwright
npx playwright install
npx playwright test
# protractor-tests:
# runs-on: ubuntu-latest
Expand Down

0 comments on commit 562455b

Please sign in to comment.