Skip to content

Commit

Permalink
Rework Makefile to remove npm-ci target
Browse files Browse the repository at this point in the history
This seems cleaner than having a target for a single command
$(MAKE) is the recommended way rather than simply make
  • Loading branch information
myieye committed Oct 20, 2022
1 parent 69b1e1a commit d04231e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ dev: start
docker compose up -d ui-builder

.PHONY: playwright-tests-ci
playwright-tests-ci: npm-ci playwright-tests
playwright-tests-ci:
npm ci
$(MAKE) playwright-tests

.PHONY: playwright-tests
playwright-tests:
npm install

# stop any containers that are running
docker compose down

Expand Down Expand Up @@ -71,10 +75,6 @@ next-dev: build
build-next:
docker compose build next-proxy next-app

.PHONY: npm-ci
npm-ci:
npm ci

.PHONY: clean
clean:
docker compose down
Expand Down

0 comments on commit d04231e

Please sign in to comment.