Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken scroll during poor connections #1261

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Fixed broken scroll during poor connections #1261

merged 2 commits into from
Dec 7, 2021

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Dec 6, 2021 •
edited
Loading

Description

While testing #1253 , an additional use case was found to be broken when a user has a poor connection.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Demo's included with tests below

How Has This Been Tested?

  • User chooses a term deep in scroll list from the list page, then clicks on it. The list should scroll to the selected word
Screen.Recording.2021-12-06.at.10.19.58.AM.mov

Checklist:

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

@longrunningprocess longrunningprocess added the bug An existing problem with our app in production label Dec 6, 2021
@longrunningprocess longrunningprocess self-assigned this Dec 6, 2021
@longrunningprocess longrunningprocess marked this pull request as ready for review December 6, 2021 15:21
megahirt
megahirt approved these changes Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our standup discussion, this is an improvement in that it simplifies the code and fixes a bug. Even though it is still a "hack", we are simplifying the hack. Thank you for this contribution.

src/angular-app/languageforge/lexicon/editor/editor.component.ts Show resolved Hide resolved
@longrunningprocess longrunningprocess mentioned this pull request Dec 7, 2021
Closed
@longrunningprocess longrunningprocess merged commit 584f7fa into staging Dec 7, 2021
@longrunningprocess longrunningprocess deleted the bugfix/broken-scroll-during-poor-connections branch December 7, 2021 13:34
@longrunningprocess longrunningprocess mentioned this pull request Dec 7, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megahirt megahirt megahirt approved these changes

Assignees

@longrunningprocess longrunningprocess

Labels
bug An existing problem with our app in production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longrunningprocess @megahirt