Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored actions to include deployment to the staging environment #1268

Merged
merged 31 commits into from
Dec 14, 2021
Merged

Refactored actions to include deployment to the staging environment #1268

merged 31 commits into from
Dec 14, 2021

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Dec 14, 2021 •
edited
Loading

Description

This PR will will trigger automated build, test, publish and deployment actions for any pushes to develop

Type of Change

  • Engineering

Screenshots

N/A

How Has This Been Tested?

  • I originally had the trigger set up to run off changes in this branch. I verified the full workflow as well as deployment to the staging environment.

Checklist:

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

billy clark added 30 commits December 13, 2021 09:35
removed TC remnants
19dd1e2
tesing full flow
5291dcc
fixed typo
315fa06
trying to get job to trigger
4f6ea70
fixed failing unit tests
7b73d8c
try output syntax
c03003d
trying syntax to grab version for deployment
b643150
no likey pip
b3c1a9e
oops, uncommented output step
82624ee
corrected syntax
4ca8a66
forgot to echo it...
5301752
can I put it in an env var?
b2ddfcb
nope, oh well, let's see what happens with the real command
7ad2414
let's make sure the VERSION makes it through
11988e7
yay, that worked!
75969d3
trysomething a little prettier
ec3ff36
finalization of the wrokflow
f316d65
share image between jobs
ed166bc
trying out self-hosted runner
ec87e48
starting to construct command
c86dfc0
oops
626bca6
check context
a0a89c1
checking context
d046357
trying a real deployment
f0f4a6a
trying a different image
61c6a25
full run through
f857922
not ready for e2e yet ;-)
094f9ed
removed remnant from earlier testing
8ea7907
updated docs
91cef61
updated trigger
0a7f9e5
megahirt
megahirt approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

.github/workflows/build-and-deploy-images.yml Show resolved Hide resolved
docker/Makefile Show resolved Hide resolved
docker/docker-compose.yml Show resolved Hide resolved
@longrunningprocess longrunningprocess merged commit c0dcbd0 into develop Dec 14, 2021
@longrunningprocess longrunningprocess deleted the chore/refactor-actions branch December 14, 2021 17:35
@longrunningprocess longrunningprocess added the engineering Tasks which do not directly relate to a user-facing feature or fix label Dec 14, 2021
@longrunningprocess longrunningprocess restored the chore/refactor-actions branch December 14, 2021 18:53
@longrunningprocess longrunningprocess mentioned this pull request Dec 14, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megahirt megahirt megahirt approved these changes

Assignees
No one assigned
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longrunningprocess @megahirt