e2e test GHA workflow + unit test reporter #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
force-pushed
the
feature/e2eGHA
branch
2 times, most recently
from
9d16f1c
to
65f8714
Compare
This change publishes the unit test results to the PR as a comment
Run e2e tests in a separate workflow
This causes the E2E test runner to stop running on the first failed test. This is advantageous for E2E tests since they take a long time to run, and often the first failing test is where the problem lies. This should save time when running flaky E2E tests. We should be able to re-run the tests quicker with fail-fast turned on.
add a separate make target unit-tests-ci
megahirt
force-pushed
the
feature/e2eGHA
branch
from
65f8714
to
c6d8997
Compare
longrunningprocess
approved these changes
Jan 14, 2022
will trigger on push to develop for the continuous deployment workflow
megahirt
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a separate workflow for e2e test runs. The e2e tests could have been included in the existing unit-test workflow, however I chose to split it out into a separate workflow so that it can be reported as a separate line item in the PR checks.
This PR also makes the following minor changes:
This is advantageous for E2E tests since they take a long time to run, and often the first failing test is where the problem lies.
This should save time when running flaky E2E tests. We should be able to re-run the e2e tests quicker with fail-fast turned on.
Fixes #1276
Fixes #1269
Type of Change
Only keep lines below that describe this change, then delete the rest.
Testing on your branch
Checklist
qa.languageforge.org testing
Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org