Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job name for production workflows #1288

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Jan 20, 2022

Description

The job name for production workflows is wrong, see #1287 for details.

Fixes #1287

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing on your branch

N/A

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

N/A

@longrunningprocess longrunningprocess self-assigned this Jan 20, 2022
@longrunningprocess longrunningprocess added bug An existing problem with our app in production engineering Tasks which do not directly relate to a user-facing feature or fix labels Jan 20, 2022
@github-actions
Copy link

Unit Test Results

    1 files      1 suites   11s ⏱️
373 tests 373 ✔️ 0 💤 0

Results for commit 2871ad5.

@github-actions
Copy link

E2E Test Results

    1 files    47 suites   15m 17s ⏱️
313 tests 313 ✔️ 0 💤 0
323 runs  323 ✔️ 0 💤 0

Results for commit 2871ad5.

@longrunningprocess
Copy link
Contributor Author

I could also drop in a change for the "extra" v in some of the unconventional areas below:

image

Conventionally, docker images don't have the v. I introduced this in #1284 but just decided to leave it alone until I spoke with someone about it.

Also here: image

I assumed it's not a big deal to leave it but if we want to fix it, it's literally a one character change right here: https://github.com/sillsdev/web-languageforge/blob/develop/.github/workflows/production.yml#L16. We'd simply add the v into the substitution, e.g., sed 's/refs\/tags\/v//'

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longrunningprocess longrunningprocess merged commit f7a6fbe into develop Jan 21, 2022
@longrunningprocess longrunningprocess deleted the issue/1287-wrong-job-name branch January 21, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing problem with our app in production engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: job name is wrong
2 participants