chore: move custom base-php files to proper location #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1299 Move the files referenced by the base-php image to the base-php folder. They used to be part of the app image, but when we moved to a base-php image build, we forgot to move the custom files. This commit puts them in the appropriate place.
longrunningprocess
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the files referenced by the base-php image to the base-php folder. They used to be part of the app image, but when we moved to a base-php image build, we forgot to move the custom files. This commit puts them in the appropriate place.
Note, I do not believe that it is necessary to rebuild the base-php image as this change does not involve any functional difference to the existing image.
Fixes #1299
Checklist