Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split README into multiple files #1320

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Conversation

megahirt
Copy link
Collaborator

@megahirt megahirt commented Mar 9, 2022

This PR splits the one long README into several files:

CONTRIBUTING.md
docs/ACKNOWLEDGEMENTS.md
docs/RELEASE.md
docs/DEVELOPER.md

It also moves the files in the former "docs" folder to a new folder called "sample_data", since that is what it actually is. The "docs" folder is an open-source repo convention used for various markdown files like I have put above. The CONTRIBUTING.md file is recognized by GitHub as a special file and will be displayed on the PR page.

A future PR will include more specific information on how to contribute.

Type of Change

Documentation update

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message

Rename docs -> sample_data and move inside test/common folder for a more permanent place.

We will use the docs folder for public repo documentation.
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Unit Test Results

    1 files      1 suites   9s ⏱️
373 tests 373 ✔️ 0 💤 0

Results for commit f24b524.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@longrunningprocess longrunningprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this cleanup, thank you! If you don't mind updating the PR description, I think this looks good to go in my mind.

README.md Outdated Show resolved Hide resolved
Other Resources is now a MD list
@megahirt
Copy link
Collaborator Author

megahirt commented Mar 9, 2022

I love this cleanup, thank you! If you don't mind updating the PR description, I think this looks good to go in my mind.

Yes, I pushed the PR quickly without taking the time to update the description. Done, thank you.

@megahirt megahirt merged commit fcc0c75 into develop Mar 9, 2022
@megahirt megahirt deleted the chore/ReadMeContributingMd branch March 9, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants