Optimize creation of login storage state files #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now skip creating the file if it already exists and has a creation date less than 1 year old (since that's the default lifetime of the "Remember Me" cookies that Silex creates). This means that the slowness of logging in five times through the UI (which takes about 20 seconds on a relatively fast developer machine) will only happen once per machine.
megahirt
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
LGTM thanks Robin.
Per our conversation, can you use the path variable on line 50 that you define on line 42?
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now skip creating the file if it already exists and has a creation date less than 1 year old (since that's the default lifetime of the "Remember Me" cookies that Silex creates). This means that the slowness of logging in five times through the UI (which takes about 20 seconds on a relatively fast developer machine) will only happen once per machine.
Checklist