Change password playwright tests #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmunn
reviewed
Mar 25, 2022
megahirt
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Great job @JeanneSon and @rmunn - you are paving the way for our E2E tests and in this PR we have established a good pattern:
- we have a beforeAll() which opens the tab
- each test() will re-use the existing tab
- each playwright file will be a unit. Multiple files should be able to be run in parallel
- test fixtures provide setup data for the application and ease of accessing that metadata
* Tab fixtures: extract data setup into own function This is in preparation for creating new admin/member/etc. fixtures that parallel adminTab, memberTab, etc., but which don't create a new browser context; they will only carry data. * Add new UserDetails fixtures (faster than UserTab) If you just need user details like username, password, etc., it's overkill to request a whole adminTab or memberTab just to access its username and password. Instead, we create 'admin' and 'member' (and so on) fixtures to just contain the data. These fixtures are extremely fast to create, speeding up some tests that didn't need a full browser tab. * Speed up change password tests by reusing fixtures In some cases, it can make sense to reuse a browser context fixture for efficiency's sake (it can take a second or two to create a new browser context). The "change password" tests are one such case, because the tests don't actually need a new browser tab for the ones that simply verify whether a button is disabled. Note that when beforeEach was changed to beforeAll, we had to remove the page.close() and context.close() calls from the fixture setup. Otherwise we'd have closed changePasswordPage over that browser tab instance and then immediately closed it when the fixture went out of scope at the end of beforeAll. Which would result in every test failing due to its browser tab having been closed! In this commit, we also use the more-efficient member fixtures instead of memberTab when all we want is the username and password. * Improve TypeScript typing of test function With the `test.extend` feature in Playwright, it's better to extend it once with a large number of fixture definitions, rather than extend it multiple times with one fixture each. The former results in a much nicer TypeScript type overlay when you over over the `test` function later.
JeanneSon
force-pushed
the
chore/changePasswordTests
branch
from
728f7ba
to
188262c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following tests have been converted to playwright
Bellows E2E Change Password app
✓ setup: login as user, go to change password page
✓ refuses to allow form submission if the confirm input does not match
✓ allows form submission if the confirm input matches
[previously commented out] should not allow a password less than 7 characters
✓ can successfully changes user's password after form submission
For details/remarks regarding converting the above tests, refer to the spreadsheet; https://docs.google.com/spreadsheets/d/1w9wjfm-02QHLhv0ObPAKKlqnDWeag379GIXwOcRU4W0/edit#gid=0
Type of Change
E2E test
Screenshots
Checklist