Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TestControl API, rename testControl.ts to testSetup #1365

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

rmunn
Copy link
Collaborator

@rmunn rmunn commented Mar 29, 2022

New API entries in testSetup.ts:

  • initTestProject to create new, empty project
  • addCustomField to add a custom field to a project
  • addLexEntry to add a lexical entry to a project
  • getProjectJson for help with logging or expect()ing project config
  • changePassword API moved from testControl.ts to testSetup.ts

Also added some examples in example.spec.ts showing how to use the
testSetup API. Each example is in a test.skip block so that they will
not actually run by default.

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

Unit Test Results

    1 files      1 suites   11s ⏱️
373 tests 373 ✔️ 0 💤 0

Results for commit 29d9db0.

♻️ This comment has been updated with latest results.

New API entries in testSetup.ts:

* initTestProject to create new, empty project
* addCustomField to add a custom field to a project
* addLexEntry to add a lexical entry to a project
* getProjectJson for help with logging or expect()ing project config
* changePassword API moved from testControl.ts to testSetup.ts

Also added some examples in example.spec.ts showing how to use the
testSetup API. Each example is in a `test.skip` block so that they will
not actually run by default.
@rmunn rmunn force-pushed the chore/more-e2e-testcontrol-functions branch from bff0e2c to 8b41f53 Compare March 30, 2022 04:05
@rmunn rmunn requested a review from megahirt March 30, 2022 08:51
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmunn lots of great improvements you're building into the testSetup. Can you remove the new_method() from this PR? Thanks!

test/e2e/utils/TestControl.php Outdated Show resolved Hide resolved
test/e2e/utils/TestControl.php Outdated Show resolved Hide resolved
@rmunn
Copy link
Collaborator Author

rmunn commented Mar 30, 2022

@rmunn lots of great improvements you're building into the testSetup. Can you remove the new_method() from this PR? Thanks!

@megahirt Done.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@rmunn rmunn merged commit d932203 into develop Mar 30, 2022
@rmunn rmunn deleted the chore/more-e2e-testcontrol-functions branch March 30, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants