Hide prev/next entry control on mobile #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
requested changes
Mar 31, 2022
There was a problem hiding this comment.
This looks like it gets the job done. Now that dc-rendered-on-desktop is being used for a different control, I think it would make more sense to rename it to hide-on-mobile or similar. Can you rename the class across the our codebase to reflect what it is actually doing?
|
Done, refactored to hide-on-mobile |
megahirt
approved these changes
Apr 5, 2022
megahirt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added "dc-rendered-on-desktop" class to parent button bar div to hide it on mobile.
Fixes #1290
Type of Change
Screenshots
Desktop(chrome)
Mobile(android)
Testing on your branch
Checklist
qa.languageforge.org testing
Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org