Fix bug where Part of Speech wasn't saving #1368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should also fix the bug with other fields like list fields, as the root cause of the bug was the same.
Description
The Part of Speech field wasn't saving properly due to an error in the DeepDiffDecoder logic. It was working when I tested it, but then I made a change to fix saving MultiText fields and failed to notice that that change would have an effect on list fields like Part of Speech. (Because both MultiText fields and list fields end with a path component called "value" in the final position, and that's what I was checking for).
Fixes #1248.
Type of Change
Only keep lines below that describe this change, then delete the rest.
Testing on your branch
Checklist
I'll add E2E regression tests later, but I've verified the fix works by manual testing. I'd like to get this merged and deployed today if possible.
qa.languageforge.org testing
Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org