Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Part of Speech wasn't saving #1368

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

rmunn
Copy link
Collaborator

@rmunn rmunn commented Mar 31, 2022

Should also fix the bug with other fields like list fields, as the root cause of the bug was the same.

Description

The Part of Speech field wasn't saving properly due to an error in the DeepDiffDecoder logic. It was working when I tested it, but then I made a change to fix saving MultiText fields and failed to notice that that change would have an effect on list fields like Part of Speech. (Because both MultiText fields and list fields end with a path component called "value" in the final position, and that's what I was checking for).

Fixes #1248.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • Bug fix (non-breaking change which fixes an issue)

Testing on your branch

  • Load a project
  • Have at least two lexical entries
  • Change the part of speech of entry 1
  • Go to entry 2
  • Go back to entry 1
  • Verify that the part of speech change was kept

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

I'll add E2E regression tests later, but I've verified the fix works by manual testing. I'd like to get this merged and deployed today if possible.

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Reviewer1 (YYYY-MM-DD HH:MM)
  • Reviewer2 (YYYY-MM-DD HH:MM)

@github-actions
Copy link

github-actions bot commented Mar 31, 2022

Unit Test Results

    1 files      1 suites   8s ⏱️
373 tests 373 ✔️ 0 💤 0

Results for commit b836499.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should also fix the bug with other fields like list fields, as the root
cause of the bug was the same.
@rmunn rmunn force-pushed the bugfix/part-of-speech-field branch from be65ab8 to b836499 Compare March 31, 2022 03:39
@rmunn rmunn merged commit 5473523 into develop Mar 31, 2022
@rmunn rmunn deleted the bugfix/part-of-speech-field branch March 31, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: inconsistent save behavior
2 participants