Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving custom fields on senses and examples #1376

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

rmunn
Copy link
Collaborator

@rmunn rmunn commented Apr 4, 2022

Description

We were treating every field as an object, but the senses and example fields are actually arrays of objects. This was resulting in custom fields not being sent to the server in the right format, so the server was simply not seeing any custom field changes in senses or examples: only custom fields at the entry level were being saved.

Fixes #1375.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • Bug fix (non-breaking change which fixes an issue)

Testing on your branch

See #1375's repro steps.

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Reviewer1 (YYYY-MM-DD HH:MM)
  • Reviewer2 (YYYY-MM-DD HH:MM)

We were treating every field as an object, but the senses and example
fields are actually arrays of objects.
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Unit Test Results

    1 files      1 suites   12s ⏱️
373 tests 373 ✔️ 0 💤 0

Results for commit 436031c.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed @rmunn 's repo steps on his branch locally and can verify that this fixes issue
#1375

@rmunn rmunn merged commit 52e9fa7 into develop Apr 4, 2022
@rmunn rmunn deleted the bugfix/custom-fields-on-senses-and-examples branch April 4, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom fields not being saved on senses or examples
2 participants