-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects tests #1390
Merged
Merged
Projects tests #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add prepopulating functionality
This also can update the role of an existing user (same API).
When the projects of a user are counted at the beginning of the test and then at the end of the test again, one does not want tests/projects from other spec files interfere with it. The new function countSpecificProjects takes a string and only counts projects where the name contains this string.
The function gotoProjectDirectly is needed in more than one page.ts Therefore, it is moved to a new file navigation.ts in the folder utils
JeanneSon
force-pushed
the
chore/projectsTests
branch
from
May 5, 2022 03:18
2bd452c
to
c3bc74e
Compare
@rmunn wanted to rebase so that the conflicts are resolved. |
rmunn
approved these changes
May 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A minor comment about using the data-test-id
attribute rather than the id
attribute for marking specific elements to be used in the E2E tests, but nothing that should delay merging this PR. Nice work.
src/angular-app/languageforge/lexicon/settings/project-settings.component.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following tests have been converted to playwright
Bellows E2E Projects List app
for Normal User
✓ should list the project of which the user is a member
✓ should not list projects the user is not a member of
✓ can list two projects of which the user is a member
for System Admin User
✓ should list all projects
✓ should show add and delete buttons
✓ should allow the admin to add themselves to the project as member or manager
Lexicon E2E Project Access
✓ Admin added to project when accessing without membership
✓ User redirected to projects app when accessing without membership
For details/remarks regarding converting the above tests, refer to the spreadsheet; https://docs.google.com/spreadsheets/d/1w9wjfm-02QHLhv0ObPAKKlqnDWeag379GIXwOcRU4W0/edit#gid=0
Type of Change
Screenshots
Checklist