Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects tests #1390

Merged
merged 14 commits into from
May 13, 2022
Merged

Projects tests #1390

merged 14 commits into from
May 13, 2022

Conversation

JeanneSon
Copy link
Contributor

@JeanneSon JeanneSon commented Apr 25, 2022

Description

The following tests have been converted to playwright

Bellows E2E Projects List app

for Normal User
✓ should list the project of which the user is a member
✓ should not list projects the user is not a member of
✓ can list two projects of which the user is a member
 
for System Admin User
✓ should list all projects
✓ should show add and delete buttons
✓ should allow the admin to add themselves to the project as member or manager
 
Lexicon E2E Project Access
✓ Admin added to project when accessing without membership
✓ User redirected to projects app when accessing without membership

For details/remarks regarding converting the above tests, refer to the spreadsheet; https://docs.google.com/spreadsheets/d/1w9wjfm-02QHLhv0ObPAKKlqnDWeag379GIXwOcRU4W0/edit#gid=0

Type of Change

  • E2E test

Screenshots

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

@JeanneSon JeanneSon added the testing Pertaining to unit or e2e testing label Apr 25, 2022
@JeanneSon JeanneSon requested a review from megahirt April 25, 2022 08:01
@JeanneSon JeanneSon self-assigned this Apr 25, 2022
@JeanneSon JeanneSon changed the title Chore/projects tests Projects tests Apr 25, 2022
@github-actions
Copy link

github-actions bot commented Apr 25, 2022

Unit Test Results

    1 files      1 suites   7s ⏱️
373 tests 373 ✔️ 0 💤 0

Results for commit f40bd3f.

♻️ This comment has been updated with latest results.

When the projects of a user are counted at the beginning of the test
and then at the end of the test again, one does not want tests/projects
from other spec files interfere with it.
The new function countSpecificProjects takes a string and only
counts projects where the name contains this string.
The function gotoProjectDirectly is needed in more than one page.ts
Therefore, it is moved to a new file navigation.ts in the folder
utils
@JeanneSon
Copy link
Contributor Author

@rmunn wanted to rebase so that the conflicts are resolved.

@JeanneSon JeanneSon marked this pull request as ready for review May 5, 2022 03:20
@JeanneSon JeanneSon requested a review from rmunn May 5, 2022 03:20
Copy link
Collaborator

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A minor comment about using the data-test-id attribute rather than the id attribute for marking specific elements to be used in the E2E tests, but nothing that should delay merging this PR. Nice work.

@JeanneSon JeanneSon removed the request for review from megahirt May 13, 2022 03:49
@JeanneSon JeanneSon merged commit 3ecf326 into develop May 13, 2022
@JeanneSon JeanneSon deleted the chore/projectsTests branch May 13, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pertaining to unit or e2e testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants