Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce lfmerge container size #1405

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

rmunn
Copy link
Collaborator

@rmunn rmunn commented May 18, 2022

This PR bumps the lfmerge image version in order to reduce the size of the lfmerge image. The reduced size may not be immediately visible with this PR, as it will still have to download a 700 MB layer in the Docker image. But with the changes I've made to the lfmerge build process, that should be the last time that Docker image layer has to be downloaded, and subsequent lfmerge releases should be able to reuse the same layer.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • Bug fix (non-breaking change which fixes an issue)

Instructions for testing

  • In the docker directory, run make.
  • Pay attention to the SHA sum of the layer that's 699 MB in size.
  • Now edit docker/lfmerge/Dockerfile and change version 2.0.111 to 2.0.112.
  • Without running make clean, run make again.
  • Pay attention to the layer whose SHA sum you noted earlier. Note that it's not re-downloading because it's already in your Docker cache.

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Reviewer1 (YYYY-MM-DD HH:MM)
  • Reviewer2 (YYYY-MM-DD HH:MM)

The reduced size may not be immediately visible with this commit, as it
will still have to download a 700 MB layer in the Docker image. But with
the changes I've made to the lfmerge build process, that should be the
last time that Docker image layer has to be downloaded, and subsequent
lfmerge releases should be able to reuse the same layer.
@github-actions
Copy link

Unit Test Results

    1 files      1 suites   10s ⏱️
373 tests 373 ✔️ 0 💤 0

Results for commit 0ca6b09.

@rmunn rmunn merged commit e8045ef into develop May 19, 2022
@rmunn rmunn deleted the chore/smaller-lfmerge-container branch May 19, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants