Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor entry tests #1408

Merged
merged 17 commits into from
Sep 8, 2022
Merged

Editor entry tests #1408

merged 17 commits into from
Sep 8, 2022

Commits on Sep 5, 2022

  1. Improve function adding lexical entries

    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    69ce8ec View commit details
    Browse the repository at this point in the history

  2. Convert about a third of the editor tests

    @JeanneSon @megahirt
    JeanneSon authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    45938e5 View commit details
    Browse the repository at this point in the history

  3. Add testSeup API to add media files to a project

    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4ce42bf View commit details
    Browse the repository at this point in the history

  4. Fix uploading media files

    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    d2a53fe View commit details
    Browse the repository at this point in the history

  5. Fix uploading media files 

    Can't use the LexUploadCommands methods after all, as they expect PHP's
special $_FILES array to exist, and user code can't touch that array. So
we copy the guts of those methods into TestControl.php instead.
    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    f15d602 View commit details
    Browse the repository at this point in the history

  6. Allow adding writing systems to test projects 

    Usage: add_writing_system_to_project('testlangproj', 'th-Zxxx-x-audio')
    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4becc12 View commit details
    Browse the repository at this point in the history

  7. Fix PHP error in testSetup file upload functions

    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c7e275d View commit details
    Browse the repository at this point in the history

  8. Change how we copy media files to E2E container 

    We'll use a shared folder instead of trying to handle uploads in PHP
    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    e02fa0c View commit details
    Browse the repository at this point in the history

  9. Fix copying media files to E2E container 

    Got the path slightly wrong earlier
    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7cf606f View commit details
    Browse the repository at this point in the history

  10. Convert more editor tests

    @JeanneSon @megahirt
    JeanneSon authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    69f22d4 View commit details
    Browse the repository at this point in the history

  11. Fix adding users to projects 

    The project model was being updated with the user, but the user model
wasn't being updated with the project, resulting in the share dialog
not finding the user as a project member. Fixed now.
    @rmunn @megahirt
    rmunn authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    34beea5 View commit details
    Browse the repository at this point in the history

  12. Finish editor test conversion, not yet cleaned-up

    @JeanneSon @megahirt
    JeanneSon authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    35430f2 View commit details
    Browse the repository at this point in the history

  13. Clean-up editor entry tests

    @JeanneSon @megahirt
    JeanneSon authored and megahirt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    746caa1 View commit details
    Browse the repository at this point in the history

  14. Fix failing test

    @JeanneSon
    JeanneSon committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    258d841 View commit details
    Browse the repository at this point in the history

  15. Add test testing navigation to other entries 

    The protractor tests test navigation from one entry to another
implicitly. Playwright directly jumps to an entry to test it.
Therefore, an explicite test for navigating from one entry to
another using the side bar on the left was added.
    @JeanneSon
    JeanneSon committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b012363 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Fix some TODOs

    @JeanneSon
    JeanneSon committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    1f0172e View commit details
    Browse the repository at this point in the history

  2. Add comments for understanding; clean-up

    @JeanneSon
    JeanneSon committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    effc032 View commit details
    Browse the repository at this point in the history