Convert to lowercase before email lookup #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where a user could not login because they are accustomed to case-sensitive email addresses.
8 tasks
longrunningprocess
approved these changes
Jun 6, 2022
rmunn
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Agreed, this is better than doing a case-insensitive search with Mongo, because in Mongo that requires using the $regex matcher and emails can have all kinds of characters that have special meanings in regex, such as the widely-used robin.munn+sometag@gmail.com feature. So my solution would have required extensive testing of the regex quoting, whereas if we know that we are already storing all email addresses in lowercased form, then this is better.
rmunn
added a commit
that referenced
this pull request
Jun 7, 2022
…loyment This reverts commit b92397e. After deployment we will revert this revert and restore the feature.
rmunn
added a commit
that referenced
this pull request
Jun 7, 2022
…loyment This reverts the revert of this feature, which can be merged into our next deployment.
|
Tested on QA. No Issues, all tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where a user could not login because they are accustomed to case-sensitive email addresses. This is a simpler implementation of #1419 , given that we know that all our email addresses are already lowercase.
Fixes #1418
Type of Change
Only keep lines below that describe this change, then delete the rest.
Testing on your branch
Locally on develop, sign-up for an account and then login using your email address (lowercase). Verify that it works. Now, logout and login with part of the email typed with capital letters e.g.
Me@example.comYou will get an invalid username/password error.Now on this branch, repeat the testing and verify that capital letters in the email address login field do not make a difference. You should be able to login using e.g.
ME@example.comjust fine.Checklist
qa.languageforge.org testing
Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org