Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mobile users to create non-S/R projects #1429

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Jun 30, 2022

Description

An alert was covering the buttons used to create a new project in the scenario where it was a non-S/R project and the user was on a mobile device.

Fixes #1411

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Bug demo:

Screen.Recording.2022-06-30.at.1.42.11.PM.mov

Corrected:

Screen.Recording.2022-06-30.at.1.44.29.PM.mov

Testing on your branch

Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.

  • Attempt to create a new non-S/R project while on a mobile device and ensure the Next button is visible to the user
  • Attempt to create a new non-S/R project while on a desktop and ensure the Next button is visible to the user

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Joseph (2022-07-05)
  • Robin (2022-07-14)

@longrunningprocess longrunningprocess self-assigned this Jun 30, 2022
@github-actions
Copy link

Unit Test Results

373 tests   373 ✔️  10s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit b5460aa.

@longrunningprocess
Copy link
Contributor Author

Please note the only unfortunate piece about this particular solution is that the project name field loses its autofocus convenience. I briefly worked to get the alert to scrollIntoView() but realized it won't win against the autofocus... I decided not to spend too much time on this since this capability has a short life expectancy.

@longrunningprocess longrunningprocess marked this pull request as ready for review June 30, 2022 17:50
@longrunningprocess longrunningprocess merged commit a8d5248 into develop Jul 5, 2022
@longrunningprocess longrunningprocess deleted the bugfix/issue-1411-new-non-sr-on-mobile branch July 5, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Can not create a non-S/R project on mobile due to element overlap
2 participants