Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

had to ensure app and lfmerge run on same node #1434

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Aug 10, 2022

Description

We learned that lfmerge's inotify will only receive messages from the kernel when the kernel is the same kernel used to write the files into place, i.e., lf-app in this case. Therefore, app and lfmerge must run on the same node until another mechanism can be considered that will work in a remote nfs environment.

Type of Change

Only keep lines below that describe this change, then delete the rest.

Screenshots

N/A

Testing on your branch

  • A simple S/R smoke test will suffice

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Reviewer1 (YYYY-MM-DD HH:MM)
  • Reviewer2 (YYYY-MM-DD HH:MM)

@longrunningprocess longrunningprocess self-assigned this Aug 10, 2022
@longrunningprocess longrunningprocess added the engineering Tasks which do not directly relate to a user-facing feature or fix label Aug 10, 2022
@github-actions
Copy link

github-actions bot commented Aug 10, 2022

Unit Test Results

368 tests   368 ✔️  9s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit bb53109.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
@longrunningprocess longrunningprocess enabled auto-merge (squash) August 11, 2022 12:45
@longrunningprocess longrunningprocess merged commit 27ed2f1 into develop Aug 11, 2022
@longrunningprocess longrunningprocess deleted the chore/k8s-config-couple-app-lfmerge branch August 11, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants