delete 3 unused dev dependencies #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deletes three obsolete/unused devDependencies, all of which were preventing a proper npm install from completing. With this change, there are no peer dependency issues. I also regenerate the package-lock.json from scratch (delete and recreate)
longrunningprocess
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This deletes three obsolete/unused devDependencies, all of which were preventing a proper
npm installfrom completing. With this change, there are no peer dependency issues/errors.I did a search in vscode for each of these dependencies and none of them appear in actual code (one had a type definition but that was it). These were likely left over from a previous refactor but the dependency wasn't removed from packages.json
I also regenerate the package-lock.json from scratch (delete and recreate)
Fixes #1436
Type of Change
Only keep lines below that describe this change, then delete the rest.
Screenshots
This change gets npm working again (It's unclear to me how it stopped working for new installs).
Checklist